Add a trivial read buffer to flexnbd-proxy.
Since the vast majority (something like 94% on boot) are sequential small reads, and since network latency is a major factor in determining how fast the exposed device appears to the client, it makes sense for us to try to minimise the number of network requests where we safely can. This patch implements the simplest possible read cache in flexnbd-proxy. When it receives a read request, if it's a small request then flexnbd-proxy will double the length of data requested. On receiving the data from the upstream server, flexnbd-proxy will return the first half to the downstream as normal, and stash the second half in a buffer. If the very next request is a read, and the offset and length match those of what we have stored, that second request will be satisfied from the buffer without going out over the network. The cache is invalidated by any non-read request, or by a disconnection.
This commit is contained in:
@@ -102,7 +102,7 @@ class TestProxyMode < Test::Unit::TestCase
|
||||
assert_equal ::FlexNBD::REQUEST_MAGIC, req1[:magic]
|
||||
assert_equal ::FlexNBD::REQUEST_READ, req1[:type]
|
||||
assert_equal 0, req1[:from]
|
||||
assert_equal 4096, req1[:len]
|
||||
assert_not_equal 0, req1[:len]
|
||||
|
||||
# Kill the server again, now we're sure the read request has been sent once
|
||||
sc1.close
|
||||
|
Reference in New Issue
Block a user