Rearranged the project to have src/ and build/ directories

This simplifies keeping everything clean.

.hgignore

@@ -1,3 +1,5 @@
 .o$
 ~$
 ^flexnbd$
+^build/
+^pkg/

Rakefile

@@ -1,7 +1,8 @@
 DEBUG  = true
 
-SOURCES = %w( flexnbd ioutil readwrite serve util parse control remote )
+SOURCES = FileList['src/*.c']
-OBJECTS = SOURCES.map { |s| "#{s}.o" }
+OBJECTS = SOURCES.pathmap( "%{^src,build}X.o" )
+
 LIBS    = %w( pthread )
 CCFLAGS = %w( -Wall )
 LDFLAGS = []
@@ -15,52 +16,66 @@ if DEBUG
 end
 
 desc "Build flexnbd binary"
-rule 'default' => 'flexnbd'
+task :flexnbd => 'build/flexnbd'
 
 namespace "test" do
   desc "Run all tests"
   task 'run' => ["unit", "scenarios"]
-  
+
   desc "Build C tests"
-  task 'build' => TEST_MODULES.map { |n| "tests/check_#{n}" }
+  task 'build' => TEST_MODULES.map { |n| "build/tests/check_#{n}" }
-  
+
   desc "Run C tests"
   task 'unit' => 'build' do
     TEST_MODULES.each do |n|
       ENV['EF_DISABLE_BANNER'] = '1'
-      sh "./tests/check_#{n}"
+      sh "build/tests/check_#{n}"
     end
   end
-  
+
   desc "Run NBD test scenarios"
   task 'scenarios' => 'flexnbd' do
     sh "cd tests; ruby nbd_scenarios"
   end
 end
 
+
 def gcc_link(target, objects)
+  FileUtils.mkdir_p File.dirname( target )
+
   sh "gcc #{LDFLAGS.join(' ')} "+
     LIBS.map { |l| "-l#{l}" }.join(" ")+
+    " -I src" +
     " -o #{target} "+
     objects.join(" ")
 end
 
-rule 'flexnbd' => OBJECTS do |t|
+rule 'build/flexnbd' => OBJECTS do |t|
   gcc_link(t.name, t.sources)
 end
 
-rule(/tests\/check_[a-z]+$/ => [ proc { |target| [target+".o", "util.o"] } ]) do |t|
+TEST_MODULES.each do |m|
-  gcc_link(t.name, t.sources + [LIBCHECK])
+  deps = ["tests/check_#{m}.c", "build/util.o"]
+  maybe_obj_name = "build/#{m}.o"
+
+  deps << maybe_obj_name if OBJECTS.include?( maybe_obj_name )
+
+  file "build/tests/check_#{m}" => deps do |t|
+    gcc_link(t.name, deps + [LIBCHECK])
+  end
 end
 
-rule '.o' => '.c' do |t|
+
-  sh "gcc -I. -c #{CCFLAGS.join(' ')} -o #{t.name} #{t.source} "
+OBJECTS.zip( SOURCES ).each do |o,c|
+  file o => c do |t|
+    FileUtils.mkdir_p File.dirname( o )
+    sh "gcc -Isrc -c #{CCFLAGS.join(' ')} -o #{o} #{c} "
+  end
 end
 
 desc "Remove all build targets, binaries and temporary files"
 rule 'clean' do
-  sh "rm -f *~ flexnbd " + (
+  sh "rm -rf *~ build " + (
-    OBJECTS + 
     TEST_MODULES.map { |n| ["tests/check_#{n}", "tests/check_#{n}.o"] }.flatten
   ).
   join(" ")

tests/nbd_scenarios

@@ -13,39 +13,39 @@ class NBDScenarios < Test::Unit::TestCase
     @available_ports = [*40000..41000] - listening_ports
     @port1 = @available_ports.shift
     @port2 = @available_ports.shift
-    @nbd1 = FlexNBD.new("../flexnbd", @ip, @port1)
+    @nbd1 = FlexNBD.new("../build/flexnbd", @ip, @port1)
-  end 
+  end
-  
+
   def teardown
     @nbd1.kill rescue nil
     [@filename1, @filename2].each do |f|
       File.unlink(f) if File.exists?(f)
     end
   end
-  
+
   def test_read1
     writefile1("f"*64)
     serve1
-    
+
     [0, 12, 63].each do |num|
-    
+
       assert_equal(
-        @nbd1.read(num*@blocksize, @blocksize), 
+        @nbd1.read(num*@blocksize, @blocksize),
         @file1.read(num*@blocksize, @blocksize)
       )
     end
-    
+
     [124, 1200, 10028, 25488].each do |num|
       assert_equal(@nbd1.read(num, 4), @file1.read(num, 4))
     end
   end
-  
+
-  # Check that we're not 
+  # Check that we're not
   #
   def test_writeread1
     writefile1("0"*64)
     serve1
-    
+
     [0, 12, 63].each do |num|
       data = "X"*@blocksize
       @nbd1.write(num*@blocksize, data)
@@ -53,14 +53,14 @@ class NBDScenarios < Test::Unit::TestCase
       assert_equal(data, @nbd1.read(num*@blocksize, data.size))
     end
   end
-  
+
   # Check that we're not overstepping or understepping where our writes end
   # up.
   #
   def test_writeread2
     writefile1("0"*1024)
     serve1
-    
+
     d0 = "\0"*@blocksize
     d1 = "X"*@blocksize
     (0..63).each do |num|
@@ -70,16 +70,16 @@ class NBDScenarios < Test::Unit::TestCase
       assert_equal(d0, @nbd1.read(((2*num)+1)*@blocksize, d0.size))
     end
   end
-  
+
   protected
   def serve1(*acl)
     @nbd1.serve(@ip, @port1, @filename1, *acl)
   end
-  
+
   def writefile1(data)
     @file1 = TestFileWriter.new(@filename1, @blocksize).write(data)
   end
-  
+
   def listening_ports
     `netstat -ltn`.
       split("\n").