bytemark/flexnbd-c
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove a compile-time optional selection of O_DIRECT (was never used)

Browse Source 
The mmap() manpage tells us to avoid using O_DIRECT with mmap() - so
do so.
This commit is contained in:
nick
2014-02-24 13:47:29 +00:00
parent 8cf92af900
commit 97c8d7a358
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/common/ioutil.c
View File

@@ -80,13 +80,8 @@ int open_and_mmap(const char* filename, int* out_fd, off64_t *out_size, void **o
{ {
off64_t size; off64_t size;
/* O_DIRECT seems to be intermittently supported. Leaving it as /* O_DIRECT should not be used with mmap() */
* a compile-time option for now. */
#ifdef DIRECT_IO
*out_fd = open(filename, O_RDWR | O_DIRECT | O_SYNC );
#else
*out_fd = open(filename, O_RDWR | O_SYNC ); *out_fd = open(filename, O_RDWR | O_SYNC );
#endif
if (*out_fd < 1) { if (*out_fd < 1) {
warn("open(%s) failed: does it exist?", filename); warn("open(%s) failed: does it exist?", filename);