bytemark/flexnbd-c
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Rubocop

Browse Source
This commit is contained in:
Patrick J Cherry
2018-02-02 21:34:14 +00:00
parent 1b7b688f7a
commit 9c48da82cc
40 changed files with 666 additions and 858 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
tests/acceptance/environment.rb
View File

@@ -1,5 +1,3 @@
# encoding: utf-8
require 'flexnbd'
require 'file_writer'
@@ -9,14 +7,14 @@ class Environment
def initialize
@blocksize = 1024
@filename1 = "/tmp/.flexnbd.test.#{$$}.#{Time.now.to_i}.1"
@filename2 = "/tmp/.flexnbd.test.#{$$}.#{Time.now.to_i}.2"
@ip = "127.0.0.1"
@available_ports = [*40000..41000] - listening_ports
@filename1 = "/tmp/.flexnbd.test.#{$PROCESS_ID}.#{Time.now.to_i}.1"
@filename2 = "/tmp/.flexnbd.test.#{$PROCESS_ID}.#{Time.now.to_i}.2"
@ip = '127.0.0.1'
@available_ports = [*40_000..41_000] - listening_ports
@port1 = @available_ports.shift
@port2 = @available_ports.shift
@nbd1 = FlexNBD::FlexNBD.new("../../build/flexnbd", @ip, @port1)
@nbd2 = FlexNBD::FlexNBD.new("../../build/flexnbd", @ip, @port2)
@nbd1 = FlexNBD::FlexNBD.new('../../build/flexnbd', @ip, @port1)
@nbd2 = FlexNBD::FlexNBD.new('../../build/flexnbd', @ip, @port2)
@fake_pid = nil
end
@@ -29,11 +27,11 @@ class Environment
def proxy1(port = @port2)
@nbd1.proxy(@ip, port)
end
def proxy2(port = @port1)
@nbd2.proxy(@ip, port)
end
def serve1(*acl)
@nbd1.serve(@filename1, *acl)
end
@@ -42,7 +40,6 @@ class Environment
@nbd2.serve(@filename2, *acl)
end
def listen1(*acl)
@nbd1.listen(@filename1, *(acl.empty? ? @acl1 : acl))
end
@@ -51,7 +48,6 @@ class Environment
@nbd2.listen(@filename2, *acl)
end
def break1
@nbd1.break
end
@@ -64,7 +60,6 @@ class Environment
@nbd2.acl(*acl)
end
def status1
@nbd1.status.first
end
@@ -73,8 +68,6 @@ class Environment
@nbd2.status.first
end
def mirror12
@nbd1.mirror(@nbd2.ip, @nbd2.port)
end
@@ -87,7 +80,6 @@ class Environment
@nbd1.mirror_unlink(@nbd2.ip, @nbd2.port, 2)
end
def write1(data)
@nbd1.write(0, data)
end
@@ -100,20 +92,17 @@ class Environment
@file2 = FileWriter.new(@filename2, @blocksize).write(data)
end
def truncate1(size)
system "truncate -s #{size} #{@filename1}"
end
def listening_ports
`netstat -ltn`.
split("\n").
map { |x| x.split(/\s+/) }[2..-1].
map { |l| l[3].split(":")[-1].to_i }
`netstat -ltn`
.split("\n")
.map { |x| x.split(/\s+/) }[2..-1]
.map { |l| l[3].split(':')[-1].to_i }
end
def cleanup
if @fake_pid
begin
@@ -122,41 +111,35 @@ class Environment
end
end
@nbd1.can_die(0)
@nbd1.kill
@nbd2.kill
[@filename1, @filename2].each do |f|
File.unlink(f) if File.exists?(f)
File.unlink(f) if File.exist?(f)
end
end
def run_fake(name, addr, port, sock = nil)
fakedir = File.join( File.dirname( __FILE__ ), "fakes" )
fakeglob = File.join( fakedir, name ) + "*"
fake = Dir[fakeglob].sort.find { |fn|
fakedir = File.join(File.dirname(__FILE__), 'fakes')
fakeglob = File.join(fakedir, name) + '*'
fake = Dir[fakeglob].sort.find do |fn|
File.executable?(fn)
}
end
raise "no fake executable at #{fakeglob}" unless fake
raise "no addr" unless addr
raise "no port" unless port
raise 'no addr' unless addr
raise 'no port' unless port
@fake_pid = fork do
exec [fake, addr, port, @nbd1.pid, sock].map{|x| x.to_s}.join(" ")
exec [fake, addr, port, @nbd1.pid, sock].map(&:to_s).join(' ')
end
sleep(0.5)
end
def fake_reports_success
_, status = Process.waitpid2(@fake_pid)
@fake_pid = nil
status.success?
end
end # class Environment

13
tests/acceptance/fakes/dest/break_after_hello.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# Open a server, accept a client, then cancel the migration by issuing
# a break command.
@@ -13,23 +11,22 @@ client = server.accept
ctrl = UNIXSocket.open(sock)
Process.kill("STOP", src_pid.to_i)
Process.kill('STOP', src_pid.to_i)
ctrl.write("break\n")
ctrl.close_write
client.write_hello
Process.kill("CONT", src_pid.to_i)
Process.kill('CONT', src_pid.to_i)
fail "Unexpected control response" unless
raise 'Unexpected control response' unless
ctrl.read =~ /0: mirror stopped/
client2 = nil
begin
client2 = server.accept( "Expected timeout" )
fail "Unexpected reconnection"
client2 = server.accept('Expected timeout')
raise 'Unexpected reconnection'
rescue Timeout::Error
# expected
end
client.close
exit(0)

9
tests/acceptance/fakes/dest/close_after_entrust_reply.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# Receive a mirror, and disconnect after sending the entrust reply but
# before it can send the disconnect signal.
#
@@ -15,7 +13,7 @@ server = FakeDest.new( addr, port )
client = server.accept
client.write_hello
while (req = client.read_request; req[:type] == 1)
while req = client.read_request; req[:type] == 1
client.read_data(req[:len])
client.write_reply(req[:handle])
end
@@ -26,11 +24,10 @@ client.close
system "kill -CONT #{src_pid}"
sleep(0.25)
client2 = server.accept( "Timed out waiting for a reconnection" )
client2 = server.accept('Timed out waiting for a reconnection')
client2.close
server.close
$stderr.puts "done"
warn 'done'
exit(0)

4
tests/acceptance/fakes/dest/close_after_hello.rb
View File

@@ -11,11 +11,11 @@ include FlexNBD
addr, port = *ARGV
server = FakeDest.new(addr, port)
client = server.accept( "Timed out waiting for a connection" )
client = server.accept('Timed out waiting for a connection')
client.write_hello
client.close
new_client = server.accept( "Timed out waiting for a reconnection" )
new_client = server.accept('Timed out waiting for a reconnection')
new_client.close
server.close

4
tests/acceptance/fakes/dest/close_after_write.rb
View File

@@ -12,12 +12,12 @@ include FlexNBD
addr, port = *ARGV
server = FakeDest.new(addr, port)
client = server.accept( "Timed out waiting for a connection" )
client = server.accept('Timed out waiting for a connection')
client.write_hello
client.read_request
client.close
new_client = server.accept( "Timed out waiting for a reconnection" )
new_client = server.accept('Timed out waiting for a reconnection')
new_client.close
server.close

6
tests/acceptance/fakes/dest/close_after_writes.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# Open a server, accept a client, then we expect a single write
# followed by an entrust. However, we disconnect after the write so
# the entrust will fail. We don't expect a reconnection: the sender
@@ -17,9 +15,9 @@ client.write_hello
req = client.read_request
data = client.read_data(req[:len])
Process.kill("STOP", src_pid.to_i)
Process.kill('STOP', src_pid.to_i)
client.write_reply(req[:handle], 0)
client.close
Process.kill("CONT", src_pid.to_i)
Process.kill('CONT', src_pid.to_i)
exit(0)

5
tests/acceptance/fakes/dest/error_on_write.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
require 'flexnbd/fake_dest'
include FlexNBD
@@ -12,8 +10,7 @@ client.write_hello
handle = client.read_request[:handle]
client.write_error(handle)
client2 = server.accept( "Timed out waiting for a reconnection" )
client2 = server.accept('Timed out waiting for a reconnection')
client.close
client2.close

4
tests/acceptance/fakes/dest/hang_after_connect.rb
View File

@@ -26,8 +26,8 @@ client.close
# Invert the sense of the timeout exception, since we *don't* want a
# connection attempt
begin
server.accept( "Expected timeout" )
fail "Unexpected reconnection"
server.accept('Expected timeout')
raise 'Unexpected reconnection'
rescue Timeout::Error
# expected
end

6
tests/acceptance/fakes/dest/hang_after_write.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# Open a socket, say hello, receive a write, then sleep for >
# MS_REQUEST_LIMIT_SECS seconds. This should tell the source that the
# write has gone MIA, and we expect a reconnect.
@@ -15,12 +13,12 @@ client1.write_hello
client1.read_request
t = Thread.start do
client2 = server.accept( "Timed out waiting for a reconnection",
client2 = server.accept('Timed out waiting for a reconnection',
FlexNBD::MS_REQUEST_LIMIT_SECS + 2)
client2.close
end
sleep_time = if ENV.has_key?('FLEXNBD_MS_REQUEST_LIMIT_SECS')
sleep_time = if ENV.key?('FLEXNBD_MS_REQUEST_LIMIT_SECS')
ENV['FLEXNBD_MS_REQUEST_LIMIT_SECS'].to_f
else
FlexNBD::MS_REQUEST_LIMIT_SECS

6
tests/acceptance/fakes/dest/hello_wrong_magic.rb
View File

@@ -13,15 +13,15 @@ client1 = server.accept
# We don't expect a reconnection attempt.
t = Thread.new do
begin
client2 = server.accept( "Timed out waiting for a reconnection",
client2 = server.accept('Timed out waiting for a reconnection',
FlexNBD::MS_RETRY_DELAY_SECS + 1)
fail "Unexpected reconnection"
raise 'Unexpected reconnection'
rescue Timeout::Error
# expected
end
end
client1.write_hello( :magic => :wrong )
client1.write_hello(magic: :wrong)
t.join

8
tests/acceptance/fakes/dest/hello_wrong_size.rb
View File

@@ -18,21 +18,21 @@ t = Thread.new do
# so it makes no sense to continue. This means we have to invert the
# sense of the exception.
begin
client2 = server.accept( "Timed out waiting for a reconnection",
client2 = server.accept('Timed out waiting for a reconnection',
FlexNBD::MS_RETRY_DELAY_SECS + 1)
client2.close
fail "Unexpected reconnection."
raise 'Unexpected reconnection.'
rescue Timeout::Error
end
end
client.write_hello( :size => :wrong )
client.write_hello(size: :wrong)
t.join
# Now check that the source closed the first socket (yes, this was an
# actual bug)
fail "Didn't close socket" unless client.disconnected?
raise "Didn't close socket" unless client.disconnected?
exit 0

4
tests/acceptance/fakes/dest/reject_acl.rb
View File

@@ -10,15 +10,13 @@ addr, port = *ARGV
server = FakeDest.new(addr, port)
server.accept.close
begin
server.accept
fail "Unexpected reconnection"
raise 'Unexpected reconnection'
rescue Timeout::Error
# expected
end
server.close
exit(0)

2
tests/acceptance/fakes/dest/sigterm_after_hello.rb
View File

@@ -9,7 +9,7 @@ include FlexNBD
addr, port, pid = *ARGV
server = FakeDest.new(addr, port)
client = server.accept( "Timed out waiting for a connection" )
client = server.accept('Timed out waiting for a connection')
client.write_hello
Process.kill(15, pid.to_i)

4
tests/acceptance/fakes/dest/write_wrong_magic.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# Accept a connection, write hello, wait for a write request, read the
# data, then write back a reply with a bad magic field. We then
# expect a reconnect.
@@ -15,7 +13,7 @@ client = server.accept
client.write_hello
req = client.read_request
client.read_data(req[:len])
client.write_reply( req[:handle], 0, :magic => :wrong )
client.write_reply(req[:handle], 0, magic: :wrong)
client2 = server.accept
client.close

4
tests/acceptance/fakes/source/close_after_connect.rb
View File

@@ -11,13 +11,13 @@ include FlexNBD
addr, port = *ARGV
FakeSource.new( addr, port, "Failed to connect" ).close
FakeSource.new(addr, port, 'Failed to connect').close
# Sleep to be sure we don't try to connect too soon. That wouldn't
# be a problem for the destination, but it would prevent us from
# determining success or failure here in the case where we try to
# reconnect before the destination has tidied up after the first
# thread went away.
sleep(0.5)
FakeSource.new( addr, port, "Failed to reconnect" ).close
FakeSource.new(addr, port, 'Failed to reconnect').close
exit 0

9
tests/acceptance/fakes/source/close_after_entrust.rb
View File

@@ -11,10 +11,10 @@ include FlexNBD
addr, port, srv_pid = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting" )
client = FakeSource.new(addr, port, 'Timed out connecting')
client.read_hello
client.write_write_request(0, 8)
client.write_data( "12345678" )
client.write_data('12345678')
# Use system "kill" rather than Process.kill because Process.kill
# doesn't seem to work
@@ -25,12 +25,11 @@ client.close
system "kill -CONT #{srv_pid}"
sleep(0.25)
begin
client2 = FakeSource.new( addr, port, "Expected timeout" )
fail "Unexpected reconnection"
client2 = FakeSource.new(addr, port, 'Expected timeout')
raise 'Unexpected reconnection'
rescue Timeout::Error
# expected
end

10
tests/acceptance/fakes/source/close_after_entrust_reply.rb
View File

@@ -10,10 +10,10 @@ include FlexNBD
addr, port, srv_pid = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting" )
client = FakeSource.new(addr, port, 'Timed out connecting')
client.read_hello
client.write_write_request(0, 8)
client.write_data( "12345678" )
client.write_data('12345678')
client.write_entrust_request
client.read_response
@@ -21,13 +21,11 @@ client.close
sleep(0.25)
begin
client2 = FakeSource.new( addr, port, "Expected timeout" )
fail "Unexpected reconnection"
client2 = FakeSource.new(addr, port, 'Expected timeout')
raise 'Unexpected reconnection'
rescue Timeout::Error
# expected
end
exit(0)

5
tests/acceptance/fakes/source/close_after_hello.rb
View File

@@ -12,13 +12,12 @@ include FlexNBD
addr, port = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting." )
client = FakeSource.new(addr, port, 'Timed out connecting.')
client.read_hello
client.close
sleep(0.2)
FakeSource.new( addr, port, "Timed out reconnecting." )
FakeSource.new(addr, port, 'Timed out reconnecting.')
exit(0)

6
tests/acceptance/fakes/source/close_after_write.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# We connect, pause the server, issue a write request, disconnect,
# then cont the server. This ensures that our disconnect happens
# while the server is trying to read the write data.
@@ -10,7 +8,7 @@ include FlexNBD
addr, port, srv_pid = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting" )
client = FakeSource.new(addr, port, 'Timed out connecting')
client.read_hello
system "kill -STOP #{srv_pid}"
@@ -24,7 +22,7 @@ system "kill -CONT #{srv_pid}"
sleep(0.25)
# ...and can we reconnect?
client2 = FakeSource.new( addr, port, "Timed out connecting" )
client2 = FakeSource.new(addr, port, 'Timed out connecting')
client2.close
exit(0)

8
tests/acceptance/fakes/source/close_after_write_data.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# We connect, pause the server, issue a write request, send data,
# disconnect, then cont the server. This ensures that our disconnect
# happens before the server can try to write the reply.
@@ -10,13 +8,13 @@ include FlexNBD
addr, port, srv_pid = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting" )
client = FakeSource.new(addr, port, 'Timed out connecting')
client.read_hello
system "kill -STOP #{srv_pid}"
client.write_write_request(0, 8)
client.write_data( "12345678" )
client.write_data('12345678')
client.close
system "kill -CONT #{srv_pid}"
@@ -27,7 +25,7 @@ system "kill -CONT #{srv_pid}"
sleep(0.25)
# ...and can we reconnect?
client2 = FakeSource.new( addr, port, "Timed out reconnecting" )
client2 = FakeSource.new(addr, port, 'Timed out reconnecting')
client2.close
exit(0)

3
tests/acceptance/fakes/source/close_mid_read.rb
View File

@@ -8,10 +8,9 @@ include FlexNBD
addr, port, srv_pid, newaddr, newport = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting" )
client = FakeSource.new(addr, port, 'Timed out connecting')
client.write_read_request(0, 8)
client.read_raw(4)
client.close
exit(0)

4
tests/acceptance/fakes/source/connect_during_hello.rb
View File

@@ -10,9 +10,9 @@ include FlexNBD
addr, port = *ARGV
client1 = FakeSource.new( addr, port, "Timed out connecting" )
client1 = FakeSource.new(addr, port, 'Timed out connecting')
sleep(0.25)
client2 = FakeSource.new( addr, port, "Timed out connecting a second time" )
client2 = FakeSource.new(addr, port, 'Timed out connecting a second time')
# This is the expected source crashing after connect
client1.close

5
tests/acceptance/fakes/source/connect_from_banned_ip.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# We connect from a local address which should be blocked, sleep for a
# bit, then try to read from the socket. We should get an instant EOF
# as we've been cut off by the destination.
@@ -11,10 +9,9 @@ include FlexNBD
addr, port = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting", "127.0.0.6" )
client = FakeSource.new(addr, port, 'Timed out connecting', '127.0.0.6')
sleep(0.25)
rsp = client.disconnected? ? 0 : 1
client.close
exit(rsp)

6
tests/acceptance/fakes/source/hang_after_hello.rb
View File

@@ -7,10 +7,10 @@
# listening for an incoming migration.
addr, port = *ARGV
require "flexnbd/fake_source"
require 'flexnbd/fake_source'
include FlexNBD
client = FakeSource.new( addr, port, "Timed out connecting" )
client = FakeSource.new(addr, port, 'Timed out connecting')
client.read_hello
# Now we do two things:
@@ -25,7 +25,7 @@ kidpid = fork do
client.close
new_client = nil
sleep(FlexNBD::CLIENT_MAX_WAIT_SECS + 1)
new_client = FakeSource.new( addr, port, "Timed out reconnecting." )
new_client = FakeSource.new(addr, port, 'Timed out reconnecting.')
new_client.read_hello
exit 0
end

4
tests/acceptance/fakes/source/sigterm_after_hello.rb
View File

@@ -9,10 +9,10 @@ include FlexNBD
addr, port, pid = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting." )
client = FakeSource.new(addr, port, 'Timed out connecting.')
client.read_hello
Process.kill( "TERM", pid.to_i )
Process.kill('TERM', pid.to_i)
sleep(0.2)
client.close

5
tests/acceptance/fakes/source/successful_transfer.rb
View File

@@ -9,10 +9,9 @@ include FlexNBD
addr, port, srv_pid, newaddr, newport = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting" )
client.send_mirror()
client = FakeSource.new(addr, port, 'Timed out connecting')
client.send_mirror
sleep(1)
exit(0)

16
tests/acceptance/fakes/source/write_out_of_range.rb
View File

@@ -1,6 +1,4 @@
#!/usr/bin/env ruby
# encoding: utf-8
# Connect, read the hello then make a write request with an impossible
# (from,len) pair. We expect an error response, and not to be
# disconnected.
@@ -13,20 +11,20 @@ include FlexNBD
addr, port = *ARGV
client = FakeSource.new( addr, port, "Timed out connecting" )
client = FakeSource.new(addr, port, 'Timed out connecting')
hello = client.read_hello
client.write_write_request( hello[:size]+1, 32, "myhandle" )
client.write_data("1"*32)
client.write_write_request(hello[:size] + 1, 32, 'myhandle')
client.write_data('1' * 32)
response = client.read_response
fail "Not an error" if response[:error] == 0
fail "Wrong handle" unless "myhandle" == response[:handle]
raise 'Not an error' if response[:error] == 0
raise 'Wrong handle' unless response[:handle] == 'myhandle'
client.write_write_request(0, 32)
client.write_data( "2"*32 )
client.write_data('2' * 32)
success_response = client.read_response
fail "Second write failed" unless success_response[:error] == 0
raise 'Second write failed' unless success_response[:error] == 0
client.close
exit(0)

55
tests/acceptance/file_writer.rb
View File

@@ -3,13 +3,13 @@
#
class FileWriter
def initialize(filename, blocksize)
@fh = File.open(filename, "w+")
@fh = File.open(filename, 'w+')
@blocksize = blocksize
@pattern = ""
@pattern = ''
end
def size
@blocksize * @pattern.split("").size
@blocksize * @pattern.split('').size
end
# We write in fixed block sizes, given by "blocksize"
@@ -20,8 +20,8 @@ class FileWriter
def write(data)
@pattern += data
data.split("").each do |code|
if code == "_"
data.split('').each do |code|
if code == '_'
@fh.seek(@blocksize, IO::SEEK_CUR)
else
@fh.write(data(code))
@@ -31,15 +31,14 @@ class FileWriter
self
end
# Returns what the data ought to be at the given offset and length
#
def read_original(off, len)
patterns = @pattern.split( "" )
patterns.zip( (0...patterns.length).to_a ).
map { |blk, blk_off|
patterns = @pattern.split('')
patterns.zip((0...patterns.length).to_a)
.map do |blk, blk_off|
data(blk, blk_off)
}.join[off...(off+len)]
end.join[off...(off + len)]
end
# Read what's actually in the file
@@ -62,14 +61,14 @@ class FileWriter
def data(code, at = @fh.tell)
case code
when "0", "_"
when '0', '_'
"\0" * @blocksize
when "X"
"X" * @blocksize
when "f"
r = ""
when 'X'
'X' * @blocksize
when 'f'
r = ''
(@blocksize / 4).times do
r += [at].pack("I")
r += [at].pack('I')
at += 4
end
r
@@ -77,51 +76,49 @@ class FileWriter
raise "Unknown character '#{block}'"
end
end
end
if __FILE__==$0
if $PROGRAM_NAME == __FILE__
require 'tempfile'
require 'test/unit'
class FileWriterTest < Test::Unit::TestCase
def test_read_original_zeros
Tempfile.open("test_read_original_zeros") do |tempfile|
Tempfile.open('test_read_original_zeros') do |tempfile|
tempfile.close
file = FileWriter.new(tempfile.path, 4096)
file.write( "0" )
file.write('0')
assert_equal file.read(0, 4096), file.read_original(0, 4096)
assert( file.untouched?(0,4096) , "Untouched file was touched." )
assert(file.untouched?(0, 4096), 'Untouched file was touched.')
end
end
def test_read_original_offsets
Tempfile.open("test_read_original_offsets") do |tempfile|
Tempfile.open('test_read_original_offsets') do |tempfile|
tempfile.close
file = FileWriter.new(tempfile.path, 4096)
file.write( "f" )
file.write('f')
assert_equal file.read(0, 4096), file.read_original(0, 4096)
assert( file.untouched?(0,4096) , "Untouched file was touched." )
assert(file.untouched?(0, 4096), 'Untouched file was touched.')
end
end
def test_file_size
Tempfile.open("test_file_size") do |tempfile|
Tempfile.open('test_file_size') do |tempfile|
tempfile.close
file = FileWriter.new(tempfile.path, 4096)
file.write( "f" )
file.write('f')
assert_equal 4096, File.stat(tempfile.path).size
end
end
def test_read_original_size
Tempfile.open("test_read_original_offsets") do |tempfile|
Tempfile.open('test_read_original_offsets') do |tempfile|
tempfile.close
file = FileWriter.new(tempfile.path, 4)
file.write( "f"*4 )
file.write('f' * 4)
assert_equal 4, file.read_original(0, 4).length
end
end
end
end

170
tests/acceptance/flexnbd.rb
View File

@@ -7,25 +7,22 @@ require 'rexml/streamlistener'
Thread.abort_on_exception = true
class Executor
attr_reader :pid
def run(cmd)
@pid = fork do exec cmd end
@pid = fork { exec cmd }
end
end # class Executor
class ValgrindExecutor
attr_reader :pid
def run(cmd)
@pid = fork do exec "valgrind --track-origins=yes --suppressions=custom.supp #{cmd}" end
@pid = fork { exec "valgrind --track-origins=yes --suppressions=custom.supp #{cmd}" }
end
end # class ValgrindExecutor
class ValgrindKillingExecutor
attr_reader :pid
@@ -34,9 +31,9 @@ class ValgrindKillingExecutor
attr_reader :backtrace
def initialize
@backtrace = []
@what = ""
@kind = ""
@pid = ""
@what = ''
@kind = ''
@pid = ''
end
def add_frame
@@ -58,10 +55,8 @@ class ValgrindKillingExecutor
def to_s
([@what + " (#{@kind}) in #{@pid}"] + @backtrace.map { |h| "#{h[:file]}:#{h[:line]} #{h[:fn]}" }).join("\n")
end
end # class Error
class ErrorListener
include REXML::StreamListener
def initialize(killer)
@@ -74,39 +69,36 @@ class ValgrindKillingExecutor
@text = text
end
def tag_start(tag, attrs)
def tag_start(tag, _attrs)
case tag.to_s
when "error"
when 'error'
@found = true
when "frame"
when 'frame'
@error.add_frame
end
end
def tag_end(tag)
case tag.to_s
when "what"
when 'what'
@error.what = @text if @found
@text = ""
when "kind"
@text = ''
when 'kind'
@error.kind = @text if @found
when "file"
when 'file'
@error.add_file(@text) if @found
when "fn"
when 'fn'
@error.add_fn(@text) if @found
when "line"
when 'line'
@error.add_line(@text) if @found
when "error", "stack"
if @found
@killer.call( @error )
end
when "pid"
when 'error', 'stack'
@killer.call(@error) if @found
when 'pid'
@error.pid = @text
end
end
end # class ErrorListener
class DebugErrorListener < ErrorListener
def text(txt)
print txt
@@ -124,47 +116,41 @@ class ValgrindKillingExecutor
end
end
def initialize
@pid = nil
end
def run(cmd)
@io_r, io_w = IO.pipe
@pid = fork do exec( "valgrind --suppressions=custom.supp --xml=yes --xml-fd=#{io_w.fileno} " + cmd ) end
@pid = fork { exec("valgrind --suppressions=custom.supp --xml=yes --xml-fd=#{io_w.fileno} " + cmd) }
launch_watch_thread(@pid, @io_r)
@pid
end
def call(err)
$stderr.puts "*"*72
$stderr.puts "* Valgrind error spotted:"
$stderr.puts err.to_s.split("\n").map{|s| " #{s}"}
$stderr.puts "*"*72
Process.kill( "KILL", @pid )
warn '*' * 72
warn '* Valgrind error spotted:'
warn err.to_s.split("\n").map { |s| " #{s}" }
warn '*' * 72
Process.kill('KILL', @pid)
exit(1)
end
private
def pick_listener
ENV['DEBUG'] ? DebugErrorListener : ErrorListener
end
def launch_watch_thread(pid, io_r)
def launch_watch_thread(_pid, io_r)
Thread.start do
io_source = REXML::IOSource.new(io_r)
listener = pick_listener.new(self)
REXML::Document.parse_stream(io_source, listener)
end
end
end # class ValgrindExecutor
module FlexNBD
# Noddy test class to exercise FlexNBD from the outside for testing.
#
@@ -189,12 +175,11 @@ module FlexNBD
end
end
def build_debug_opt
if @do_debug
"--verbose"
'--verbose'
else
"--quiet"
'--quiet'
end
end
@@ -213,16 +198,14 @@ module FlexNBD
@prefetch_proxy = false
end
def debug?
!!@do_debug
end
def debug(msg)
$stderr.puts msg if debug?
warn msg if debug?
end
def serve_cmd(file, acl)
"#{bin} serve "\
"--addr #{ip} "\
@@ -233,7 +216,6 @@ module FlexNBD
"#{acl.join(' ')}"
end
def listen_cmd(file, acl)
"#{bin} listen "\
"--addr #{ip} "\
@@ -250,11 +232,10 @@ module FlexNBD
"--port #{port} "\
"--conn-addr #{connect_ip} "\
"--conn-port #{connect_port} "\
"#{prefetch_proxy ? "--cache " : ""}"\
"#{prefetch_proxy ? '--cache ' : ''}"\
"#{@debug}"
end
def read_cmd(offset, length)
"#{bin} read "\
"--addr #{ip} "\
@@ -264,7 +245,6 @@ module FlexNBD
"--size #{length}"
end
def write_cmd(offset, data)
"#{bin} write "\
"--addr #{ip} "\
@@ -274,7 +254,6 @@ module FlexNBD
"--size #{data.length}"
end
def base_mirror_opts(dest_ip, dest_port)
"--addr #{dest_ip} "\
"--port #{dest_port} "\
@@ -283,7 +262,7 @@ module FlexNBD
def unlink_mirror_opts(dest_ip, dest_port)
"#{base_mirror_opts(dest_ip, dest_port)} "\
"--unlink "
'--unlink '
end
def base_mirror_cmd(opts)
@@ -316,46 +295,52 @@ module FlexNBD
"#{@bin} acl " \
"--sock #{ctrl} "\
"#{@debug} "\
"#{acl.join " "}"
"#{acl.join ' '}"
end
def run_serve_cmd(cmd)
File.unlink(ctrl) if File.exists?(ctrl)
File.unlink(ctrl) if File.exist?(ctrl)
debug(cmd)
@pid = @executor.run(cmd)
while !File.socket?(ctrl)
until File.socket?(ctrl)
pid, status = Process.wait2(@pid, Process::WNOHANG)
raise "server did not start (#{cmd})" if pid
sleep 0.1
end
start_wait_thread(@pid)
at_exit { kill }
end
private :run_serve_cmd
def serve(file, *acl)
cmd = serve_cmd(file, acl)
run_serve_cmd(cmd)
sleep( 0.2 ) until File.exists?( ctrl )
sleep(0.2) until File.exist?(ctrl)
end
def listen(file, *acl)
run_serve_cmd(listen_cmd(file, acl))
end
def tcp_server_open?
# raises if the other side doesn't accept()
sock = TCPSocket.new(ip, port) rescue nil
sock = begin
TCPSocket.new(ip, port)
rescue StandardError
nil
end
success = !!sock
( sock.close rescue nil) if sock
if sock
(begin
sock.close
rescue StandardError
nil
end)
end
success
end
@@ -375,27 +360,25 @@ module FlexNBD
at_exit { kill }
end
def start_wait_thread(pid)
@wait_thread = Thread.start do
_, status = Process.waitpid2(pid)
if @kill
if status.signaled?
fail "flexnbd quit with a bad signal: #{status.inspect}" unless
raise "flexnbd quit with a bad signal: #{status.inspect}" unless
@kill.include? status.termsig
else
fail "flexnbd quit with a bad status: #{status.inspect}" unless
raise "flexnbd quit with a bad status: #{status.inspect}" unless
@kill.include? status.exitstatus
end
else
$stderr.puts "flexnbd #{self.pid} quit"
fail "flexnbd #{self.pid} quit early with status #{status.to_i}"
warn "flexnbd #{self.pid} quit"
raise "flexnbd #{self.pid} quit early with status #{status.to_i}"
end
end
end
def can_die(*status)
status = [0] if status.empty?
@kill += status
@@ -407,7 +390,7 @@ module FlexNBD
can_die(1)
if @pid
begin
Process.kill("INT", @pid)
Process.kill('INT', @pid)
rescue Errno::ESRCH => e
# already dead. Presumably this means it went away after a
# can_die() call.
@@ -423,7 +406,7 @@ module FlexNBD
IO.popen(cmd) do |fh|
return fh.read
end
raise IOError.new "NBD read failed" unless $?.success?
raise IOError, 'NBD read failed' unless $CHILD_STATUS.success?
out
end
@@ -431,27 +414,24 @@ module FlexNBD
cmd = write_cmd(offset, data)
debug(cmd)
IO.popen(cmd, "w") do |fh|
IO.popen(cmd, 'w') do |fh|
fh.write(data)
end
raise IOError.new "NBD write failed" unless $?.success?
raise IOError, 'NBD write failed' unless $CHILD_STATUS.success?
nil
end
def join
@wait_thread.join
end
def mirror_unchecked( dest_ip, dest_port, bandwidth=nil, action=nil, timeout=nil )
def mirror_unchecked(dest_ip, dest_port, _bandwidth = nil, _action = nil, timeout = nil)
cmd = mirror_cmd(dest_ip, dest_port)
debug(cmd)
maybe_timeout(cmd, timeout)
end
def mirror_unlink(dest_ip, dest_port, timeout = nil)
cmd = mirror_unlink_cmd(dest_ip, dest_port)
debug(cmd)
@@ -459,11 +439,11 @@ module FlexNBD
maybe_timeout(cmd, timeout)
end
def maybe_timeout(cmd, timeout = nil)
stdout, stderr = "",""
stdout = ''
stderr = ''
stat = nil
run = Proc.new do
run = proc do
# Ruby 1.9 changed the popen3 api. instead of 3 args, the block
# gets 4. Not only that, but it no longer sets $?, so we have to
# go elsewhere for the process' exit status.
@@ -473,7 +453,7 @@ module FlexNBD
stderr.replace io_err.read
stat = maybe_thr.value if maybe_thr
end
stat ||= $?
stat ||= $CHILD_STATUS
end
if timeout
@@ -485,16 +465,13 @@ module FlexNBD
[stdout, stderr, stat]
end
def mirror(dest_ip, dest_port, bandwidth = nil, action = nil)
stdout, stderr, status = mirror_unchecked(dest_ip, dest_port, bandwidth, action)
raise IOError.new( "Migrate command failed\n" + stderr) unless status.success?
raise IOError, "Migrate command failed\n" + stderr unless status.success?
stdout
end
def break(timeout = nil)
cmd = break_cmd
debug(cmd)
@@ -502,7 +479,6 @@ module FlexNBD
maybe_timeout(cmd, timeout)
end
def acl(*acl)
cmd = acl_cmd(*acl)
debug(cmd)
@@ -510,9 +486,8 @@ module FlexNBD
maybe_timeout(cmd, 2)
end
def status(timeout = nil)
cmd = status_cmd()
cmd = status_cmd
debug(cmd)
o, e = maybe_timeout(cmd, timeout)
@@ -520,50 +495,43 @@ module FlexNBD
[parse_status(o), e]
end
def launched?
!!@pid
end
def paused
Process.kill( "STOP", @pid )
Process.kill('STOP', @pid)
yield
ensure
Process.kill( "CONT", @pid )
Process.kill('CONT', @pid)
end
protected
def control_command(*args)
raise "Server not running" unless @pid
raise 'Server not running' unless @pid
args = args.compact
UNIXSocket.open(@ctrl) do |u|
u.write(args.join("\n") + "\n")
code, message = u.readline.split(": ", 2)
code, message = u.readline.split(': ', 2)
return [code, message]
end
end
def parse_status(status)
hsh = {}
status.split(" ").each do |part|
status.split(' ').each do |part|
next if part.strip.empty?
a,b = part.split("=")
a, b = part.split('=')
b.strip!
b = true if b == "true"
b = false if b == "false"
b = true if b == 'true'
b = false if b == 'false'
hsh[a.strip] = b
end
hsh
end
end
end

26
tests/acceptance/flexnbd/constants.rb
View File

@@ -1,10 +1,7 @@
# encoding: utf-8
module FlexNBD
def self.binary(str)
if str.respond_to? :force_encoding
str.force_encoding "ASCII-8BIT"
str.force_encoding 'ASCII-8BIT'
else
str
end
@@ -13,36 +10,33 @@ module FlexNBD
# eeevil is his one and only name...
def self.read_constants
parents = []
current = File.expand_path(".")
while current != "/"
current = File.expand_path('.')
while current != '/'
parents << current
current = File.expand_path( File.join( current, ".." ) )
current = File.expand_path(File.join(current, '..'))
end
source_root = parents.find do |dirname|
File.directory?( File.join( dirname, "src" ) )
File.directory?(File.join(dirname, 'src'))
end
fail "No source root!" unless source_root
raise 'No source root!' unless source_root
headers = Dir[File.join( source_root, "src", "{common,proxy,server}","*.h" ) ]
headers = Dir[File.join(source_root, 'src', '{common,proxy,server}', '*.h')]
headers.each do |header_filename|
txt_lines = File.readlines(header_filename)
txt_lines.each do |line|
if line =~ /^#\s*define\s+([A-Z0-9_]+)\s+(\d+)\s*$/
# Bodge until I can figure out what to do with #ifdefs
const_set($1, $2.to_i) unless const_defined?( $1 )
const_set(Regexp.last_match(1), Regexp.last_match(2).to_i) unless const_defined?(Regexp.last_match(1))
end
end
end
end
end
read_constants()
read_constants
REQUEST_MAGIC = binary("\x25\x60\x95\x13") unless defined?(REQUEST_MAGIC)
REPLY_MAGIC = binary("\x67\x44\x66\x98") unless defined?(REPLY_MAGIC)
end # module FlexNBD

50
tests/acceptance/flexnbd/fake_dest.rb
View File

@@ -1,5 +1,3 @@
# encoding: utf-8
require 'socket'
require 'timeout'
@@ -7,15 +5,13 @@ require 'flexnbd/constants'
module FlexNBD
class FakeDest
class Client
def initialize(sock)
@sock = sock
end
def write_hello(opts = {})
@sock.write( "NBDMAGIC" )
@sock.write('NBDMAGIC')
if opts[:magic] == :wrong
write_rand(@sock, 8)
@@ -32,13 +28,11 @@ module FlexNBD
@sock.write("\x00" * 128)
end
def write_rand(sock, len)
len.times do sock.write( rand(256).chr ) end
len.times { sock.write(rand(256).chr) }
end
def read_request()
def read_request
req = @sock.read(28)
magic_s = req[0...4]
@@ -48,11 +42,11 @@ module FlexNBD
len_s = req[24...28]
{
:magic => magic_s,
:type => type_s.unpack("N").first,
:handle => handle_s,
:from => self.class.parse_be64( from_s ),
:len => len_s.unpack( "N").first
magic: magic_s,
type: type_s.unpack('N').first,
handle: handle_s,
from: self.class.parse_be64(from_s),
len: len_s.unpack('N').first
}
end
@@ -61,14 +55,12 @@ module FlexNBD
end
def disconnected?
begin
Timeout.timeout(2) do
@sock.read(1) == nil
@sock.read(1).nil?
end
rescue Timeout::Error
return false
end
end
def write_reply(handle, err = 0, opts = {})
if opts[:magic] == :wrong
@@ -77,16 +69,14 @@ module FlexNBD
@sock.write(::FlexNBD::REPLY_MAGIC)
end
@sock.write( [err].pack("N") )
@sock.write([err].pack('N'))
@sock.write(handle)
end
def close
@sock.close
end
def read_data(len)
@sock.read(len)
end
@@ -95,25 +85,23 @@ module FlexNBD
@sock.write(len)
end
def self.parse_be64(str)
raise "String is the wrong length: 8 bytes expected (#{str.length} received)" unless
str.length == 8
top, bottom = str.unpack("NN")
top, bottom = str.unpack('NN')
(top << 32) + bottom
end
def receive_mirror(opts = {})
write_hello()
write_hello
loop do
req = read_request
case req[:type]
when 1
read_data(req[:len])
write_reply(req[:handle])
when 65536
when 65_536
write_reply(req[:handle], opts[:err] == :entrust ? 1 : 0)
break
else
@@ -129,16 +117,13 @@ module FlexNBD
raise "Not a disconnect: #{req.inspect}"
end
end
end # class Client
def initialize(addr, port)
@sock = TCPServer.new(addr, port)
end
def accept( err_msg = "Timed out waiting for a connection", timeout = 5)
def accept(err_msg = 'Timed out waiting for a connection', timeout = 5)
client_sock = nil
begin
@@ -146,7 +131,7 @@ module FlexNBD
client_sock = @sock.accept
end
rescue Timeout::Error
raise Timeout::Error.new(err_msg)
raise Timeout::Error, err_msg
end
client_sock
@@ -154,13 +139,8 @@ module FlexNBD
Client.new(client_sock)
end
def close
@sock.close
end
end # module FakeDest
end # module FlexNBD

63
tests/acceptance/flexnbd/fake_source.rb
View File

@@ -1,12 +1,9 @@
# encoding: utf-8
require 'socket'
require "timeout"
require 'timeout'
require 'flexnbd/constants'
module FlexNBD
class FakeSource
def initialize(addr, port, err_msg, source_addr = nil, source_port = 0)
timing_out(2, err_msg) do
begin
@@ -16,14 +13,13 @@ module FlexNBD
TCPSocket.new(addr, port)
end
rescue Errno::ECONNREFUSED
$stderr.puts "Connection refused, retrying"
warn 'Connection refused, retrying'
sleep(0.2)
retry
end
end
end
def close
@sock.close
end
@@ -31,7 +27,7 @@ module FlexNBD
def read_hello
timing_out(::FlexNBD::MS_HELLO_TIME_SECS,
'Timed out waiting for hello.') do
fail 'No hello.' unless (hello = @sock.read(152)) &&
raise 'No hello.' unless (hello = @sock.read(152)) &&
hello.length == 152
passwd_s = hello[0..7]
@@ -44,9 +40,8 @@ module FlexNBD
end
end
def send_request( type, handle="myhandle", from=0, len=0, magic=REQUEST_MAGIC )
fail "Bad handle" unless handle.length == 8
def send_request(type, handle = 'myhandle', from = 0, len = 0, magic = REQUEST_MAGIC)
raise 'Bad handle' unless handle.length == 8
@sock.write(magic)
@sock.write([type].pack('N'))
@@ -55,34 +50,30 @@ module FlexNBD
@sock.write([len].pack('N'))
end
def write_write_request( from, len, handle="myhandle" )
def write_write_request(from, len, handle = 'myhandle')
send_request(1, handle, from, len)
end
def write_entrust_request( handle="myhandle" )
send_request( 65536, handle )
def write_entrust_request(handle = 'myhandle')
send_request(65_536, handle)
end
def write_disconnect_request( handle="myhandle" )
def write_disconnect_request(handle = 'myhandle')
send_request(2, handle)
end
def write_read_request( from, len, handle="myhandle" )
send_request( 0, "myhandle", from, len )
def write_read_request(from, len, _handle = 'myhandle')
send_request(0, 'myhandle', from, len)
end
def write_data(data)
@sock.write(data)
end
# Handy utility
def read(from, len)
timing_out( 2, "Timed out reading" ) do
send_request( 0, "myhandle", from, len )
timing_out(2, 'Timed out reading') do
send_request(0, 'myhandle', from, len)
read_raw(len)
end
end
@@ -92,50 +83,44 @@ module FlexNBD
end
def send_mirror
read_hello()
write( 0, "12345678" )
read_response()
write_disconnect_request()
close()
read_hello
write(0, '12345678')
read_response
write_disconnect_request
close
end
def write(from, data)
write_write_request(from, data.length)
write_data(data)
end
def read_response
magic = @sock.read(4)
error_s = @sock.read(4)
handle = @sock.read(8)
{
:magic => magic,
:error => error_s.unpack("N").first,
:handle => handle
magic: magic,
error: error_s.unpack('N').first,
handle: handle
}
end
def disconnected?
result = nil
Timeout.timeout( 2 ) { result = ( @sock.read(1) == nil ) }
Timeout.timeout(2) { result = @sock.read(1).nil? }
result
end
def timing_out(time, msg)
begin
Timeout.timeout(time) do
yield
end
rescue Timeout::Error
$stderr.puts msg
warn msg
exit 1
end
end
private
@@ -152,7 +137,5 @@ module FlexNBD
((b & 0x000000000000ff00) << 40) |
((b & 0x00000000000000ff) << 56)
end
end # class FakeSource
end # module FlexNBD

38
tests/acceptance/proxy_tests.rb
View File

@@ -1,4 +1,4 @@
# encoding: utf-8
require 'flexnbd/fake_source'
require 'flexnbd/fake_dest'
@@ -13,14 +13,17 @@ module ProxyTests
@env.nbd2.can_die(0)
client = FlexNBD::FakeSource.new(@env.ip, @env.port2, "Couldn't connect to proxy")
begin
result = client.read_hello
assert_equal "NBDMAGIC", result[:passwd]
assert_equal 'NBDMAGIC', result[:passwd]
assert_equal override_size || @env.file1.size, result[:size]
yield client
ensure
client.close rescue nil
begin
client.close
rescue StandardError
nil
end
end
end
@@ -32,11 +35,11 @@ module ProxyTests
with_proxied_client do |client|
(0..3).each do |n|
offset = n * 4096
client.write_read_request(offset, 4096, "myhandle")
client.write_read_request(offset, 4096, 'myhandle')
rsp = client.read_response
assert_equal ::FlexNBD::REPLY_MAGIC, rsp[:magic]
assert_equal "myhandle", rsp[:handle]
assert_equal 'myhandle', rsp[:handle]
assert_equal 0, rsp[:error]
orig_data = @env.file1.read(offset, 4096)
@@ -59,7 +62,7 @@ module ProxyTests
rsp = client.read_response
assert_equal FlexNBD::REPLY_MAGIC, rsp[:magic]
assert_equal "myhandle", rsp[:handle]
assert_equal 'myhandle', rsp[:handle]
assert_equal 0, rsp[:error]
data = @env.file1.read(offset, 4096)
@@ -120,12 +123,11 @@ module ProxyTests
assert_equal req1[:handle], rsp[:handle]
data = client.read_raw(4096)
assert_equal( (b * 4096), data, "Wrong data returned" )
assert_equal((b * 4096), data, 'Wrong data returned')
sc2.close
server.close
end
end
def test_write_request_retried_when_upstream_dies_partway
@@ -144,7 +146,7 @@ module ProxyTests
assert_equal 0, req1[:from]
assert_equal 4096, req1[:len]
data1 = sc1.read_data(4096)
assert_equal( ( b * 4096 ), data1, "Data not proxied successfully" )
assert_equal((b * 4096), data1, 'Data not proxied successfully')
# Kill the server again, now we're sure the read request has been sent once
sc1.close
@@ -174,8 +176,7 @@ module ProxyTests
end
def test_only_one_client_can_connect_to_proxy_at_a_time
with_proxied_client do |client|
with_proxied_client do |_client|
c2 = nil
assert_raises(Timeout::Error) do
Timeout.timeout(1) do
@@ -183,12 +184,13 @@ module ProxyTests
c2.read_hello
end
end
c2.close rescue nil if c2
if c2
begin
c2.close
rescue StandardError
nil
end
end
end
end
end

55
tests/acceptance/test_dest_error_handling.rb
View File

@@ -1,13 +1,10 @@
# encoding: utf-8
require 'test/unit'
require 'environment'
class TestDestErrorHandling < Test::Unit::TestCase
def setup
@env = Environment.new
@env.writefile1( "0" * 4 )
@env.writefile1('0' * 4)
@env.listen1
end
@@ -15,89 +12,77 @@ class TestDestErrorHandling < Test::Unit::TestCase
@env.cleanup
end
def test_hello_blocked_by_disconnect_causes_error_not_fatal
run_fake( "source/close_after_connect" )
run_fake('source/close_after_connect')
assert_no_control
end
=begin
# This is disabled while CLIENT_MAX_WAIT_SECS is removed
def test_hello_goes_astray_causes_timeout_error
run_fake( "source/hang_after_hello" )
assert_no_control
end
=end
# # This is disabled while CLIENT_MAX_WAIT_SECS is removed
# def test_hello_goes_astray_causes_timeout_error
# run_fake( "source/hang_after_hello" )
# assert_no_control
# end
def test_sigterm_has_bad_exit_status
@env.nbd1.can_die(1)
run_fake( "source/sigterm_after_hello" )
run_fake('source/sigterm_after_hello')
end
def test_disconnect_after_hello_causes_error_not_fatal
run_fake( "source/close_after_hello" )
run_fake('source/close_after_hello')
assert_no_control
end
def test_partial_read_causes_error
run_fake( "source/close_mid_read" )
run_fake('source/close_mid_read')
end
def test_double_connect_during_hello
run_fake( "source/connect_during_hello" )
run_fake('source/connect_during_hello')
end
def test_acl_rejection
@env.acl1("127.0.0.1")
run_fake( "source/connect_from_banned_ip")
@env.acl1('127.0.0.1')
run_fake('source/connect_from_banned_ip')
end
def test_bad_write
run_fake( "source/write_out_of_range" )
run_fake('source/write_out_of_range')
end
def test_disconnect_before_write_data_causes_error
run_fake( "source/close_after_write" )
run_fake('source/close_after_write')
end
def test_disconnect_before_write_reply_causes_error
# Note that this is an odd case: writing the reply doesn't fail.
# The test passes because the next attempt by flexnbd to read a
# request returns EOF.
run_fake( "source/close_after_write_data" )
run_fake('source/close_after_write_data')
end
def test_straight_migration
@env.nbd1.can_die(0)
run_fake( "source/successful_transfer" )
run_fake('source/successful_transfer')
end
private
def run_fake(name)
@env.run_fake(name, @env.ip, @env.port1)
assert @env.fake_reports_success, "#{name} failed."
end
def status
stat, _ = @env.status1
stat, = @env.status1
stat
end
def assert_no_control
assert !status['has_control'], "Thought it had control"
assert !status['has_control'], 'Thought it had control'
end
def assert_control
assert status['has_control'], "Didn't think it had control"
end
end # class TestDestErrorHandling

58
tests/acceptance/test_happy_path.rb
View File

@@ -1,5 +1,3 @@
# encoding: utf-8
require 'test/unit'
require 'environment'
require 'flexnbd/constants'
@@ -19,20 +17,18 @@ class TestHappyPath < Test::Unit::TestCase
@env.cleanup
end
def test_read1
@env.writefile1("f"*64)
@env.writefile1('f' * 64)
@env.serve1
[0, 12, 63].each do |num|
assert_equal(
bin(@env.nbd1.read(num * @env.blocksize, @env.blocksize)),
bin(@env.file1.read(num * @env.blocksize, @env.blocksize))
)
end
[124, 1200, 10028, 25488].each do |num|
[124, 1200, 10_028, 25_488].each do |num|
assert_equal(bin(@env.nbd1.read(num, 4)), bin(@env.file1.read(num, 4)))
end
end
@@ -40,11 +36,11 @@ class TestHappyPath < Test::Unit::TestCase
# Check that we're not
#
def test_writeread1
@env.writefile1("0"*64)
@env.writefile1('0' * 64)
@env.serve1
[0, 12, 63].each do |num|
data = "X"*@env.blocksize
data = 'X' * @env.blocksize
@env.nbd1.write(num * @env.blocksize, data)
assert_equal(data, @env.file1.read(num * @env.blocksize, data.size))
assert_equal(data, @env.nbd1.read(num * @env.blocksize, data.size))
@@ -55,11 +51,11 @@ class TestHappyPath < Test::Unit::TestCase
# up.
#
def test_writeread2
@env.writefile1("0"*1024)
@env.writefile1('0' * 1024)
@env.serve1
d0 = "\0" * @env.blocksize
d1 = "X"*@env.blocksize
d1 = 'X' * @env.blocksize
(0..63).each do |num|
@env.nbd1.write(num * @env.blocksize * 2, d1)
end
@@ -68,20 +64,18 @@ class TestHappyPath < Test::Unit::TestCase
end
end
def setup_to_mirror
@env.writefile1( "f"*4 )
@env.writefile1('f' * 4)
@env.serve1
@env.writefile2( "0"*4 )
@env.writefile2('0' * 4)
@env.listen2
end
def test_mirror
@env.nbd1.can_die
@env.nbd2.can_die(0)
setup_to_mirror()
setup_to_mirror
stdout, stderr = @env.mirror12
@@ -89,16 +83,15 @@ class TestHappyPath < Test::Unit::TestCase
@env.nbd2.join
assert(File.file?(@env.filename1),
"The source file was incorrectly deleted")
'The source file was incorrectly deleted')
assert_equal(@env.file1.read_original(0, @env.blocksize),
@env.file2.read(0, @env.blocksize))
end
def test_mirror_unlink
@env.nbd1.can_die(0)
@env.nbd2.can_die(0)
setup_to_mirror()
setup_to_mirror
assert File.file?(@env.filename1)
@@ -106,45 +99,40 @@ class TestHappyPath < Test::Unit::TestCase
assert_no_match(/unrecognized/, stderr)
Timeout.timeout(10) do @env.nbd1.join end
Timeout.timeout(10) { @env.nbd1.join }
assert !File.file?(@env.filename1)
end
def test_write_to_high_block
#
# This test does not work on 32 bit platforms.
#
skip("Not relevant on 32-bit platforms") if ( ["a"].pack("p").size < 8 )
skip('Not relevant on 32-bit platforms') if ['a'].pack('p').size < 8
# Create a large file, then try to write to somewhere after the 2G boundary
@env.truncate1 "4G"
@env.truncate1 '4G'
@env.serve1
@env.nbd1.write( 2**31+2**29, "12345678" )
@env.nbd1.write(2**31 + 2**29, '12345678')
sleep(1)
assert_equal "12345678", @env.nbd1.read( 2**31+2**29, 8 )
assert_equal '12345678', @env.nbd1.read(2**31 + 2**29, 8)
end
def test_set_acl
# Just check that we get sane feedback here
@env.writefile1( "f"*4 )
@env.writefile1('f' * 4)
@env.serve1
_,stderr = @env.acl1("127.0.0.1")
_, stderr = @env.acl1('127.0.0.1')
assert_no_match(/^(F|E):/, stderr)
end
def test_write_more_than_one_run
one_mb = 2**20
data = "\0" * 256 * one_mb
File.open(@env.filename1, "wb") do |f| f.write( "1" * 256 * one_mb ) end
File.open(@env.filename1, 'wb') { |f| f.write('1' * 256 * one_mb) }
@env.serve1
sleep 5
@@ -153,17 +141,15 @@ class TestHappyPath < Test::Unit::TestCase
@env.nbd1.kill
i = 0
File.open(@env.filename1, "rb") do |f|
File.open(@env.filename1, 'rb') do |f|
while mb = f.read(one_mb)
unless "\0" * one_mb == mb
msg = "Read non-zeros after offset %x:\n"%(i * one_mb)
msg = format("Read non-zeros after offset %x:\n", (i * one_mb))
msg += `hexdump #{@env.filename1} | head -n5`
fail msg
raise msg
end
i += 1
end
end
end
end

5
tests/acceptance/test_prefetch_proxy_mode.rb
View File

@@ -2,7 +2,6 @@ require 'test/unit'
require 'environment'
require 'proxy_tests'
class TestPrefetchProxyMode < Test::Unit::TestCase
include ProxyTests
@@ -10,7 +9,7 @@ class TestPrefetchProxyMode < Test::Unit::TestCase
super
@env = Environment.new
@env.prefetch_proxy!
@env.writefile1( "f" * 16 )
@env.writefile1('f' * 16)
end
def teardown
@@ -18,5 +17,3 @@ class TestPrefetchProxyMode < Test::Unit::TestCase
super
end
end

4
tests/acceptance/test_proxy_mode.rb
View File

@@ -2,14 +2,13 @@ require 'test/unit'
require 'environment'
require 'proxy_tests'
class TestProxyMode < Test::Unit::TestCase
include ProxyTests
def setup
super
@env = Environment.new
@env.writefile1( "f" * 16 )
@env.writefile1('f' * 16)
end
def teardown
@@ -17,4 +16,3 @@ class TestProxyMode < Test::Unit::TestCase
super
end
end

29
tests/acceptance/test_serve_mode.rb
View File

@@ -4,12 +4,11 @@ require 'flexnbd/fake_source'
require 'pp'
class TestServeMode < Test::Unit::TestCase
def setup
super
@b = "\xFF".b
@env = Environment.new
@env.writefile1( "0" )
@env.writefile1('0')
@env.serve1
end
@@ -19,7 +18,7 @@ class TestServeMode < Test::Unit::TestCase
end
def connect_to_server
client = FlexNBD::FakeSource.new(@env.ip, @env.port1, "Connecting to server failed")
client = FlexNBD::FakeSource.new(@env.ip, @env.port1, 'Connecting to server failed')
begin
result = client.read_hello
assert_equal 'NBDMAGIC', result[:passwd]
@@ -29,28 +28,30 @@ class TestServeMode < Test::Unit::TestCase
assert_equal "\x0" * 124, result[:reserved]
yield client
ensure
client.close rescue nil
begin
client.close
rescue StandardError
nil
end
end
end
def test_bad_request_magic_receives_error_response
connect_to_server do |client|
# replace REQUEST_MAGIC with all 0s to make it look bad
client.send_request( 0, "myhandle", 0, 0, "\x00\x00\x00\x00" )
client.send_request(0, 'myhandle', 0, 0, "\x00\x00\x00\x00")
rsp = client.read_response
assert_equal FlexNBD::REPLY_MAGIC, rsp[:magic]
assert_equal "myhandle", rsp[:handle]
assert_equal 'myhandle', rsp[:handle]
assert rsp[:error] != 0, "Server sent success reply back: #{rsp[:error]}"
# The client should be disconnected now
assert client.disconnected?, "Server not disconnected"
assert client.disconnected?, 'Server not disconnected'
end
end
def test_long_write_on_top_of_short_write_is_respected
connect_to_server do |client|
# Start with a file of all-zeroes.
client.write(0, "\x00" * @env.file1.size)
@@ -72,14 +73,13 @@ class TestServeMode < Test::Unit::TestCase
assert_equal @b * 2, @env.file1.read(0, 2)
end
def test_read_request_out_of_bounds_receives_error_response
connect_to_server do |client|
client.write_read_request(@env.file1.size, 4096)
rsp = client.read_response
assert_equal FlexNBD::REPLY_MAGIC, rsp[:magic]
assert_equal "myhandle", rsp[:handle]
assert_equal 'myhandle', rsp[:handle]
assert rsp[:error] != 0, "Server sent success reply back: #{rsp[:error]}"
# Ensure we're not disconnected by sending a request. We don't care about
@@ -96,7 +96,7 @@ class TestServeMode < Test::Unit::TestCase
rsp = client.read_response
assert_equal FlexNBD::REPLY_MAGIC, rsp[:magic]
assert_equal "myhandle", rsp[:handle]
assert_equal 'myhandle', rsp[:handle]
assert rsp[:error] != 0, "Server sent success reply back: #{rsp[:error]}"
# Ensure we're not disconnected by sending a request. We don't care about
@@ -105,10 +105,5 @@ class TestServeMode < Test::Unit::TestCase
rsp = client.read_response
assert_equal FlexNBD::REPLY_MAGIC, rsp[:magic]
end
end
end

65
tests/acceptance/test_source_error_handling.rb
View File

@@ -1,126 +1,105 @@
# encoding: utf-8
require 'test/unit'
require 'environment'
class TestSourceErrorHandling < Test::Unit::TestCase
def setup
@old_env = ENV['FLEXNBD_MS_REQUEST_LIMIT_SECS']
ENV['FLEXNBD_MS_REQUEST_LIMIT_SECS'] = "4.0"
ENV['FLEXNBD_MS_REQUEST_LIMIT_SECS'] = '4.0'
@env = Environment.new
@env.writefile1( "f" * 4 )
@env.writefile1('f' * 4)
@env.serve1
end
def teardown
@env.nbd1.can_die(0)
@env.cleanup
ENV['FLEXNBD_MS_REQUEST_LIMIT_SECS'] = @old_env
end
def expect_term_during_migration
@env.nbd1.can_die(1, 9)
end
def test_failure_to_connect_reported_in_mirror_cmd_response
stdout, stderr = @env.mirror12_unchecked
expect_term_during_migration
assert_match(/failed to connect/, stderr)
end
def test_sigterm_after_hello_quits_with_status_of_1
expect_term_during_migration
run_fake( "dest/sigterm_after_hello" )
run_fake('dest/sigterm_after_hello')
end
def test_destination_hangs_after_connect_reports_error_at_source
run_fake( "dest/hang_after_connect",
:err => /Remote server failed to respond/ )
run_fake('dest/hang_after_connect',
err: /Remote server failed to respond/)
end
def test_destination_rejects_connection_reports_error_at_source
run_fake( "dest/reject_acl",
:err => /Mirror was rejected/ )
run_fake('dest/reject_acl',
err: /Mirror was rejected/)
end
def test_wrong_size_causes_disconnect
run_fake( "dest/hello_wrong_size",
:err => /Remote size does not match local size/ )
run_fake('dest/hello_wrong_size',
err: /Remote size does not match local size/)
end
def test_wrong_magic_causes_disconnect
expect_term_during_migration
run_fake( "dest/hello_wrong_magic",
:err => /Mirror was rejected/ )
run_fake('dest/hello_wrong_magic',
err: /Mirror was rejected/)
end
def test_disconnect_after_hello_causes_retry
expect_term_during_migration
run_fake( "dest/close_after_hello",
:out => /Mirror started/ )
run_fake('dest/close_after_hello',
out: /Mirror started/)
end
def test_write_times_out_causes_retry
expect_term_during_migration
run_fake( "dest/hang_after_write" )
run_fake('dest/hang_after_write')
end
def test_rejected_write_causes_retry
expect_term_during_migration
run_fake( "dest/error_on_write" )
run_fake('dest/error_on_write')
end
def test_disconnect_before_write_reply_causes_retry
expect_term_during_migration
run_fake( "dest/close_after_write" )
run_fake('dest/close_after_write')
end
def test_bad_write_reply_causes_retry
expect_term_during_migration
run_fake( "dest/write_wrong_magic" )
run_fake('dest/write_wrong_magic')
end
def test_pre_entrust_disconnect_causes_retry
expect_term_during_migration
run_fake( "dest/close_after_writes" )
run_fake('dest/close_after_writes')
end
def test_cancel_migration
run_fake( "dest/break_after_hello" )
run_fake('dest/break_after_hello')
end
private
def run_fake(name, opts = {})
@env.run_fake(name, @env.ip, @env.port2, @env.nbd1.ctrl)
stdout, stderr = @env.mirror12_unchecked
assert_success
assert_match(opts[:err], stderr) if opts[:err]
assert_match(opts[:out], stdout) if opts[:out]
return stdout, stderr
[stdout, stderr]
end
def assert_success(msg = nil)
assert @env.fake_reports_success, msg || "Fake failed"
assert @env.fake_reports_success, msg || 'Fake failed'
end
end # class TestSourceErrorHandling

97
tests/acceptance/test_write_during_migration.rb
View File

@@ -9,102 +9,98 @@ require 'tmpdir'
Thread.abort_on_exception = true
class TestWriteDuringMigration < Test::Unit::TestCase
def setup
@flexnbd = File.expand_path("../../build/flexnbd")
raise "No binary!" unless File.executable?( @flexnbd )
@flexnbd = File.expand_path('../../build/flexnbd')
raise 'No binary!' unless File.executable?(@flexnbd)
@size = 20 * 1024 * 1024 # 20MB
@write_data = "foo!" * 2048 # 8K write
@write_data = 'foo!' * 2048 # 8K write
@source_port = 9990
@dest_port = 9991
@source_sock = "src.sock"
@dest_sock = "dst.sock"
@source_file = "src.file"
@dest_file = "dst.file"
@source_sock = 'src.sock'
@dest_sock = 'dst.sock'
@source_file = 'src.file'
@dest_file = 'dst.file'
end
def teardown
[@dst_proc, @src_proc].each do |pid|
if pid
Process.kill( "KILL", pid ) rescue nil
next unless pid
begin
Process.kill('KILL', pid)
rescue StandardError
nil
end
end
end
def debug_arg
ENV['DEBUG'] ? "--verbose" : ""
ENV['DEBUG'] ? '--verbose' : ''
end
def launch_servers
@dst_proc = fork() {
@dst_proc = fork do
cmd = "#{@flexnbd} listen -l 127.0.0.1 -p #{@dest_port} -f #{@dest_file} -s #{@dest_sock} #{debug_arg}"
exec cmd
}
end
@src_proc = fork() {
@src_proc = fork do
cmd = "#{@flexnbd} serve -l 127.0.0.1 -p #{@source_port} -f #{@source_file} -s #{@source_sock} #{debug_arg}"
exec cmd
}
end
begin
awaiting = nil
Timeout.timeout(10) do
awaiting = :source
sleep 0.1 while !File.exists?( @source_sock )
sleep 0.1 until File.exist?(@source_sock)
awaiting = :dest
sleep 0.1 while !File.exists?( @dest_sock )
sleep 0.1 until File.exist?(@dest_sock)
end
rescue Timeout::Error
case awaiting
when :source
fail "Couldn't get a source socket."
raise "Couldn't get a source socket."
when :dest
fail "Couldn't get a destination socket."
raise "Couldn't get a destination socket."
else
fail "Something went wrong I don't understand."
raise "Something went wrong I don't understand."
end
end
end
def make_files()
def make_files
FileUtils.touch(@source_file)
File.truncate(@source_file, @size)
FileUtils.touch(@dest_file)
File.truncate(@dest_file, @size)
File.open(@source_file, "wb"){|f| f.write "a"*@size }
File.open(@source_file, 'wb') { |f| f.write 'a' * @size }
end
def start_mirror
UNIXSocket.open(@source_sock) {|sock|
sock.write(["mirror", "127.0.0.1", @dest_port.to_s, "exit"].join("\x0A") + "\x0A\x0A")
UNIXSocket.open(@source_sock) do |sock|
sock.write(['mirror', '127.0.0.1', @dest_port.to_s, 'exit'].join("\x0A") + "\x0A\x0A")
sock.flush
rsp = sock.readline
}
end
end
def wait_for_quit()
def wait_for_quit
Timeout.timeout(10) do
start_time = Time.now
dst_result = Process::waitpid2(@dst_proc)
src_result = Process::waitpid2(@src_proc)
dst_result = Process.waitpid2(@dst_proc)
src_result = Process.waitpid2(@src_proc)
end
end
def source_writer
client = FlexNBD::FakeSource.new( "127.0.0.1", @source_port, "Timed out connecting" )
client = FlexNBD::FakeSource.new('127.0.0.1', @source_port, 'Timed out connecting')
offsets = Range.new(0, (@size - @write_data.size) / 4096).to_a
loop do
begin
client.write(offsets[rand(offsets.size)] * 4096, @write_data)
rescue => err
rescue StandardError => err
# We expect a broken write at some point, so ignore it
break
end
@@ -115,8 +111,8 @@ class TestWriteDuringMigration < Test::Unit::TestCase
# puts `md5sum #{@source_file} #{@dest_file}`
# Ensure each block matches
File.open(@source_file, "r") do |source|
File.open(@dest_file, "r") do |dest|
File.open(@source_file, 'r') do |source|
File.open(@dest_file, 'r') do |dest|
0.upto(@size / 4096) do |block_num|
s_data = source.read(4096)
d_data = dest.read(4096)
@@ -131,16 +127,16 @@ class TestWriteDuringMigration < Test::Unit::TestCase
end
def test_write_during_migration
Dir.mktmpdir() do |tmpdir|
Dir.mktmpdir do |tmpdir|
Dir.chdir(tmpdir) do
make_files()
make_files
launch_servers()
launch_servers
src_writer = Thread.new { source_writer }
start_mirror()
wait_for_quit()
start_mirror
wait_for_quit
src_writer.join
assert_both_sides_identical
end
@@ -148,24 +144,21 @@ class TestWriteDuringMigration < Test::Unit::TestCase
end
def test_many_clients_during_migration
Dir.mktmpdir() do |tmpdir|
Dir.mktmpdir do |tmpdir|
Dir.chdir(tmpdir) do
make_files()
make_files
launch_servers()
launch_servers
src_writers_1 = (1..5).collect { Thread.new { source_writer } }
start_mirror()
start_mirror
src_writers_2 = (1..5).collect { Thread.new { source_writer } }
wait_for_quit()
( src_writers_1 + src_writers_2 ).each {|t| t.join }
wait_for_quit
(src_writers_1 + src_writers_2).each(&:join)
assert_both_sides_identical
end
end end
end