Open files with O_DIRECT dependent on a compile-time DIRECT_IO #define.

O_DIRECT causes problems on (at least) a wheezy VM, and there are mixed
reports about its performance impact.  This patch makes it a
compile-time choice which should remain until it's been benchmarked.
This commit is contained in:
Alex Young
2012-07-14 10:07:58 +01:00
parent 03c06a689d
commit c6e6952def
3 changed files with 17 additions and 5 deletions

View File

@@ -244,11 +244,13 @@ void mirror_give_control( struct mirror * mirror )
* The entrust signifies that all the data has been sent, and
* the client is currently paused but not disconnected.
* The disconnect signifies that the client has been
* safely disconnected.
* TODO: Disconnect the client!
* safely prevented from making any more writes.
*
* Since we lock io and close the server it in mirror_on_exit before
* releasing, we don't actually need to take any action between the
* two here.
*/
socket_nbd_entrust( mirror->client );
debug("TODO: The client *should* be disconnected here, but isn't yet");
socket_nbd_disconnect( mirror->client );
}