listen: Turn off CLIENT_MAX_WAIT_SECS

The idea behind this feature was to avoid the client thread in a listen
server getting stuck forever if the mirroring thread in the source died.
However, it breaks any sane implementation of max_Bps in that thread,
and there are lingering concerns over how it might operate under normal
conditions anyway.

Specifically, if iterating over the bitmap takes a long time, or even just
reading the requisite 8MB from the disc in order to send it, then the
5-second timeout could be hit, causing mirroring to fail unnecessarily.
This commit is contained in:
nick
2013-08-14 16:09:55 +01:00
parent d0022402ae
commit efdd613968
3 changed files with 18 additions and 7 deletions

View File

@@ -21,12 +21,13 @@ class TestDestErrorHandling < Test::Unit::TestCase
assert_no_control
end
=begin
# This is disabled while CLIENT_MAX_WAIT_SECS is removed
def test_hello_goes_astray_causes_timeout_error
run_fake( "source/hang_after_hello" )
assert_no_control
end
=end
def test_sigterm_has_bad_exit_status
@env.nbd1.can_die(1)
@@ -99,3 +100,4 @@ class TestDestErrorHandling < Test::Unit::TestCase
end
end # class TestDestErrorHandling